Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an option for table.attr argument #1922

Merged
merged 4 commits into from
Jan 22, 2021
Merged

add an option for table.attr argument #1922

merged 4 commits into from
Jan 22, 2021

Conversation

cderv
Copy link
Collaborator

@cderv cderv commented Nov 25, 2020

To close rstudio/rmarkdown#1954, I find it interesting to have an option to set a table attribut for all kable using format html.

Do you fing that interesting ?

@cderv cderv requested a review from yihui November 25, 2020 15:47
@cderv
Copy link
Collaborator Author

cderv commented Nov 25, 2020

FWIW checks are failing on WINDOWS and MACOS because rgl is not available as binary yet.

@atusy

This comment has been minimized.

@cderv

This comment has been minimized.

@atusy

This comment has been minimized.

Copy link
Owner

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me. Thanks!

R/table.R Outdated Show resolved Hide resolved
@yihui yihui merged commit 5776da2 into master Jan 22, 2021
@yihui yihui deleted the table.attr-options branch January 22, 2021 20:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect format for HTML tables
3 participants