Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terms pos_x and pos_y are confusing #74

Closed
yfukai opened this issue Jul 27, 2021 · 2 comments
Closed

terms pos_x and pos_y are confusing #74

yfukai opened this issue Jul 27, 2021 · 2 comments
Labels
breaking Breaking Changes refactoring Refactoring

Comments

@yfukai
Copy link
Owner

yfukai commented Jul 27, 2021

Now, pos_x and pos_y in the result DataFrame points to the row and column positions, which are not intuitive.
It will be a breaking change, but maybe we should switch to returning np.ndarray instead.
@yfukai yfukai added breaking Breaking Changes refactoring Refactoring labels Jul 27, 2021
@yfukai yfukai mentioned this issue Jul 27, 2021
Closed
@yfukai yfukai changed the title different terms for pos_x and pos_y terms pos_x and pos_y are confusing Jul 27, 2021
@yfukai
Copy link
Owner Author

yfukai commented Sep 29, 2021 •
edited
Loading

The terms row and col with the dimensional order are also confusing and require a major (and breaking) refactoring with an appropriate warning, see #99 .
One possible way is making an optional argument to set the direction, showing a warning if it is unset.

@yfukai
Copy link
Owner Author

yfukai commented Feb 13, 2022 •
edited
Loading

Now solved in #181 and #183. row and y stand for the second last dimension and col and x for the last.

@yfukai yfukai closed this as completed Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking Breaking Changes refactoring Refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yfukai