Skip to content
This repository has been archived by the owner on Jul 19, 2020. It is now read-only.

Remove the other attribute matchers. #121

Closed
hgzimmerman opened this issue Oct 22, 2019 · 1 comment · Fixed by #129
Closed

Remove the other attribute matchers. #121

hgzimmerman opened this issue Oct 22, 2019 · 1 comment · Fixed by #129
Labels
enhancement New feature or request high priority Issues with this tag will be worked on before others

Comments

@hgzimmerman
Copy link
Member

Description

Because you can't have arbitrary syntax tokens within an attribute, you either have to use #[attr(arbitrary stuff)] or #[arbitrary] #[stuff]. I find these to be difficult to read, and harder to write than just having a block of them, or just using the routing syntax exposed by #[to=""].

Because the router syntax is a little more manageable now, it might make sense to get rid of all, or at least some of the attributes. I don't think there is a need for two separate systems.
Keeping #[rest] and #[end] are probably worthwhile, but everything else except #[to=""] should go.

@hgzimmerman hgzimmerman added the enhancement New feature or request label Oct 22, 2019
@hgzimmerman
Copy link
Member Author

This issue would remove the need for #98

@hgzimmerman hgzimmerman added the high priority Issues with this tag will be worked on before others label Oct 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request high priority Issues with this tag will be worked on before others
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant