use_effect() doesn't trigger when rendered via history::push()

[simbleau]

Problem

Steps To Reproduce

let history = use_history().unwrap();

html!{
    <button
        onclick={
            let history = history.clone();
            Callback::from(move |_| {
                history.push(_MY_ROUTE_);
            })
        }
     ></button>
}

Expected behavior
use_effect() should be triggered when I navigate to a page via history::push() through yew_router

Screenshots
If applicable, add screenshots to help explain your problem.
Expected:

Actual:

Environment:

• Yew version: 19.3
• Rust version: 1.63.1
• Target, if relevant: wasm32-unknown-emscripten
• Build tool, if relevant: trunk
• OS, if relevant: Ubuntu
• Browser and version, if relevant: Firefox

Questionnaire

• I'm interested in fixing this myself but don't know where to start
• I would like to fix and I have a solution
• I don't have time to fix this right now, but maybe later

[WorldSEnder]

Is there a branch on https://github.com/simbleau/website where I can see this live? I'm not certain which component contains the use_effect here and why you expect it to re-render.

[ranile]

Can you confirm that this bug still persists with on master? A lot of changes to hooks and router have been made.

[simbleau]

It's not from my website , it's on a private repo. I invited you as a collaborator @WorldSEnder ) - trunk serve and go to http://localhost:8080/whoami/3 and advance to the next slide (http://localhost:8080/terminal).

It is irregular, though. When switching from http://localhost:8080/ to the next slide (http://localhost:8080/terminal) the effect is triggered appropriately.

@hamza1311 Right now stylist isn't up to date for Yew 0.20 and this unfortunately causes 60+ errors on my side I'm not too keen on fixing. I've invited you as a collaborator to the repo, same as @WorldSEnder

[futursolo]

This is expected as history represents a setter and does not subscribe to changes. If you want to listen to location changes, you need to use the use_location hook.

This is better represented in master as history is wrapped in the navigator type and no longer exposed directly. Navigator does not allow reading location information from it.

[simbleau]

Thanks @futursolo

Is the appropriate fix then to use_location, or to upgrade to master?

[futursolo]

Is the appropriate fix then to use_location, or to upgrade to master?

Yes. use_history / use_navigator does not listen to changes so users can produce a components that only sets the location without it being re-rendered upon location changes (Link / Redirect).

[simbleau]

Going to close this, I have fixed the issue on my side.