Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attach event listener registry to root App (instead of body) for multi-app pages #1564

Closed
1 of 3 tasks
bakape opened this issue Sep 18, 2020 · 0 comments · Fixed by #2510
Closed
1 of 3 tasks

Attach event listener registry to root App (instead of body) for multi-app pages #1564

bakape opened this issue Sep 18, 2020 · 0 comments · Fixed by #2510
Labels
A-yew Area: The main yew crate feature-accepted A feature request that has been accepted and needs implementing feature-request A feature request
Milestone

Comments

@bakape
Copy link
Contributor

bakape commented Sep 18, 2020

Follow up for #1542

#1542 (comment)

React just moved away from using the body as the root event listener element because it causes issues when rendering multiple apps on the same document. How about we set this from app_mount instead?

Is your feature request related to a problem? Please describe. (Optional)
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe alternatives you've considered (Optional)
A clear and concise description of any alternative solutions or features you've considered.

Additional context (Optional)
Add any other context or screenshots about the feature request here.

Questionnaire

  • I'm interested in implementing this myself but don't know where to start
  • I would like to add this feature
  • I don't have time to add this right now, but maybe later
@bakape bakape added the feature-request A feature request label Sep 18, 2020
@bakape bakape mentioned this issue Sep 18, 2020
13 tasks
@mc1098 mc1098 added A-yew Area: The main yew crate feature-accepted A feature request that has been accepted and needs implementing labels Sep 20, 2021
@WorldSEnder WorldSEnder mentioned this issue Mar 18, 2022
4 tasks
@WorldSEnder WorldSEnder added this to the v0.20 milestone Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-yew Area: The main yew crate feature-accepted A feature request that has been accepted and needs implementing feature-request A feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants