-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename kind
(used as alias for type
)
#1318
Comments
@zoechi how about |
Discoverability is probably not great if it does not start with |
@zoechi I don't think discoverability is an issue, can you elaborate which API you are concerned about? |
Right, we could still use |
True, what do you think about pursuing #1322 instead? |
@jstarry see #1322 (comment) |
I'm closing this issue because this has been fixed :) I don't know when but kind as an alias for type is not used by Yew anymore 🎉 |
Describe the feature you'd like
I find
kind
as alias fortype
, which conflicts with Rust'stype
keyword, confusingand propose to change it to
type
and to use
type_
as alias wheretype
conflicts with the keyword.I'm of course open for other suggestions how to prevent the conflict,
it's just that
kind
seems too different to make a good candidate.Is your feature request related to a problem? Please describe. (Optional)
See the discussion in
#1298
It's not obvious that
kind
stands fortype
and it would need to be well documented, probably on all locations where it appears in public API.In private APIs it might still confuse contributors.
Describe alternatives you've considered (Optional)
Improve documentation
#1298 (comment)
Additional context (Optional)
Add any other context or screenshots about the feature request here.
Questionnaire
I'd try to fix this after a consensus is found what should be used instead of
type
where it causes a syntax error because of the conflict with thetype
keyword.The text was updated successfully, but these errors were encountered: