wasm32-unknown-unknown build failed

[anykao]

Add http crate break target wasm32-unknown-unknown build

Should be upstream bug?

#95

[koute]

Yep. The iovec crate checks for #[cfg(unix)] and #[cfg(windows)], and since the wasm32-unknown-unknown doesn't define either the sys namespace is empty.

Although I'm not sure what would be the point of using iovec on a target which has no use for it, so perhaps an issue should be raised in the crate which depends on the iovec?

[machineloop]

Might be worth reverting #95, while we wait for upstream fix.

[therustmonk]

Ok, I'll revert the first version of service and hide the current fetch under feature.

[Arnavion]

FYI the iovec fix PR is carllerche/iovec#10

[machineloop]

When I test things out with the iovec PR mentioned above, using [replace] in an example project cargo.toml

[replace]
"iovec:0.1.1" = { git = 'https://github.com/dflemstr/iovec', branch = 'wasm-support' }

I get the following errors in bytes:

[Arnavion]

@machineloop You can't [replace] iovec 0.1.1 with its git master. There was a breaking change to remove the From<[u8]> impls that will be released with a version-bump eventually.

[machineloop]

Thanks @Arnavion, I didn't realize there were breaking changes that hadn't been cut into an IoVec release. I took the proposed Wasm support and cherry picked the commits onto the last stable release in a fork, see the PR here: #110

[Roba1993]

How is the status on this bug here?

[gabisurita]

@Roba1993 I think this fix is probably waiting for an IoVec release.
carllerche/iovec#13

[anxiousmodernman]

The referenced PR to iovec has landed. I'm playing around with yew master branch and, while I used to need machineloop's fork to build, I don't anymore.

[anykao]

Yes, confirmed. There is no more errors after cargo update.
I'll close this issue since the upstream is patched.