Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hey guys,
here is the PR related to yetibot/yetibot#799 : Renaming the room command to channel :-)
So what do we have here :
first of all, I have renamed the
room.clj
file tochannel.clj
for more accuracy and also because I assume that the new naming scheme will be based on channel from now on.I have also extended the
Adapter
protocol by introducing a newchannels
function which (should be)/is nothing more than alias to the existingrooms
function and whose implementation should just point to the existingrooms
function implementation, for any record implementing theAdapter
protocol.I have also renamed multiple auxiliary functions whose names were related to room to instead use the word channel. Same thing for the docstrings. These are more cosmetic changes and were not necessarily important in order to have the project running. But for more accuracy within the codebase, it is nicer to have the same naming scheme used (almost) everywhere.
I have said almost everywhere in the previous sentence because of course we can not change everything containing the word room within it and especially the underlying data model related to rooms.
Therefore, a little hint for the review ^^ :
otherwise, we can get into trouble and you should let me know if you find such changes so I can fix it ;-)
Now, here is how it renders so far :
New channel command in action
The room command (maintained for compatibility)
feel free to play around with this branch guys and as usual, do not hesitate to let me know if you find any issue related to the changes introduced.
thanks \o