Handle "Nick in use" notice in IRC adapter.

[sarg]

irclj uses separate thread for connection. Whenever "nick in use" occurs it calls callback and then throws Exception which stops the thread. (https://github.com/Raynes/irclj/blob/f230935cd94dc1c86ffb6677c1b6bb8675d3df94/src/irclj/process.clj#L91)

So in order to recover this siutation I have to stop/start adapter.

[codecov]

Codecov Report

Merging #113 into master will increase coverage by <.01%.
The diff coverage is 41.46%.

@@            Coverage Diff             @@
##           master     #113      +/-   ##
==========================================
+ Coverage   43.64%   43.64%   +<.01%     
==========================================
  Files          90       90              
  Lines        3590     3622      +32     
  Branches      166      166              
==========================================
+ Hits         1567     1581      +14     
- Misses       1857     1875      +18     
  Partials      166      166

Impacted Files	Coverage Δ
src/yetibot/core/adapters/irc.clj	27.23% <41.46%> (+2.92%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b79014...492c487. Read the comment docs.

[devth]

I tested this by configuring my local Yetibot to join IRC using my own username (which is taken). The strange thing is it only re-joins 2 out of the 3 channels that it was supposed to after reconnect. Are you seeing this? Or are you testing it another way?

I'm not totally sure what's going on with this behavior, but the fix was to add (reset! current-channels #{}) to stop:

(defn stop
  "Kill the irc conection"
  [{:keys [current-channels conn]}]
  (when-let [c @conn] (irc/kill c))
  (reset! current-channels #{})
  (reset! conn nil))

This makes sense, as it will need to re-join all channels after that reconnect.

[sarg]

Yeah, I also have no clue why that is happening. I was testing only the reconnection part though. I've amended commit with your suggestion.

[devth]

@sarg awesome, thanks!

[devth]

Oops, Unable to resolve symbol: current-channels in this context after latest change.

stop should be:

(defn stop
  "Kill the irc conection"
  [{:keys [current-channels conn]}]
  (when-let [c @conn] (irc/kill c))
  (reset! current-channels #{})
  (reset! conn nil))

[sarg]

I've pushed the fix

[devth]

@sarg thanks!