Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yesod scaffold port variable incompatible with Keter #189

Open
SongWithoutWords opened this issue Oct 23, 2018 · 2 comments
Open

Yesod scaffold port variable incompatible with Keter #189

SongWithoutWords opened this issue Oct 23, 2018 · 2 comments

Comments

@SongWithoutWords
Copy link

The Yesod scaffold port environment variable is YESOD_PORT:

port: "_env:YESOD_PORT:3000" # NB: The port `yesod devel` uses is distinct from this value. Set the `yesod devel` port from the command line.

This is incompatible with the environment variable used by Keter which is PORT. The results of this discrepancy is a silent failure when deploying apps created from the Yesod scaffold with Keter, as described here: snoyberg/keter#189.

The documentation for Keter has since been updated to warn of this discrepancy, but it would be ideal if the Yesod scaffold worked with Keter out of the box.

@psibi
Copy link
Member

psibi commented Oct 23, 2018

The prefixing of YESOD was done recently. See this thread to learn more about the reasoning: yesodweb/yesod#1517 (comment)

Probably keter should be updated to make it work with the new environment variable ? A fix there would be ideal, IMO.

@SongWithoutWords
Copy link
Author

Wouldn't changing the variable on Keter's end run the risk of breaking existing server apps?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants