-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close generator / Cancel command #15
Comments
|
@SBoudrias suggestion yeoman/generator#728 (comment) to run yeoman in a ChildProcess doesn't work. There are some bugs with node / atom-shell v0.20.5 itself and the ChildProcess (electron/electron#961). Unfortunately they don't know what goes wrong and I guess it's not on the high priority list. We have to find an other solution for that problem. So from my perspective we have these options: Let it me know if you have any other ideas or opinions to address. |
Yeah, the Atom-Shell Team fixed it 😄 electron/electron#961 (comment). I will check it out tomorrow. |
@ruyadorno FYI will continue with that this week. |
awesome! 🎆 |
The generator process is not longer part of the main process of the app. The actual generator is now running in a child process so we can simple kill them and stop the npm and bower install process. For that, I've added two new context-generator events:
@ruyadorno Can you please add a new state (right after generator:install is emitted) which contains the cancel button. That would be awesome. My current working branch is called child-process-wip. If you have any questions, shout! |
We need a close button on the interface that would bring the user back to the initial app screen, in order for this to work we'll also need a new command to actually stop the running generator on the
browser
side.browser
- @stefanbuckThe text was updated successfully, but these errors were encountered: