Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve support for Yarn #980

Closed
mischah opened this issue Nov 26, 2016 · 2 comments
Closed

Improve support for Yarn #980

mischah opened this issue Nov 26, 2016 · 2 comments

Comments

@mischah
Copy link
Member

mischah commented Nov 26, 2016

Hej,

this is a follow up to #964.
I just checked changes of 4eccb2a and I see a problem with how Yarn install is implemented. Or let’s say its missing one thing:

Dependencies should be installed with yarn add lodash or yarn add --dev lodash.
See: https://yarnpkg.com/en/docs/cli/install

Installing dependencies with yarn install lodash --save or yarn install lodash --save works for now but is deprecated since the first public release of Yarn:
image

So it’s just a matter of time until it breaks.

We should extend the runinstall method to call yarn add instead of yarn install for installing dependencies.

@SBoudrias
Copy link
Member

SBoudrias commented Nov 26, 2016

Yup, totally should

@mischah
Copy link
Member Author

mischah commented Nov 26, 2016

Nice 💖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants