Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generator is too slow offline #221

Closed
SBoudrias opened this issue Jan 7, 2016 · 8 comments
Closed

Generator is too slow offline #221

SBoudrias opened this issue Jan 7, 2016 · 8 comments
Labels

Comments

@SBoudrias
Copy link
Member

We're making some requests to the github API to get data about the user. The timeout on these request is way to long and makes the generator unusable when offline.

We need to reduce the timeout to < 1-2s

@SBoudrias SBoudrias added the bug label Jan 7, 2016
@alexsantos
Copy link

At work I have a proxy configured on my Ubuntu box and can use git, bower or npm but this generator seems that isn't using it.

@alexsantos
Copy link

I've been digging on the source code and my problem starts on checking for an existing name for the package on NPM - so the problem is with the way the package "npm-name" is trying to achieve it. It uses "got" so it can't use the .npmrc configuration, for instance. Is there a better way for this?

@SBoudrias
Copy link
Member Author

@alexsantos open an issue on npm-name.

@alexsantos
Copy link

@SBoudrias Just went there and in fact there was already an Issue for this... sindresorhus/npm-name#1
The fact is that npm-name is staying with "got" as @sindresorhus stated.
My question is: what about the corporate users like myself that are behind a firewall and want to use this generator?

@SBoudrias
Copy link
Member Author

@alexsantos I don't see anywhere where the proxy issue is dismissed. The project is welcoming PR to fix this.

OSS authors works on issues they're interested in, they're not your employees. If you want proxy support now, then it's up to you to send a PR.

@sindresorhus
Copy link
Member

sindresorhus/got#79

@alexsantos
Copy link

@SBoudrias Thanks for getting back on this. I will look on this, just wondering if there was already some kind of idea for a new approach or not.
@sindresorhus 👍

@SBoudrias
Copy link
Member Author

Tested this offline and it seemed the performance was way better now.

Proxy support is still an open issue on Node side; but we won't be fixing this directly inside generator-node; so I'll close this issue as there's nothing more we can do here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants