Skip to content
This repository has been archived by the owner on Mar 26, 2018. It is now read-only.

Now using official Bootstrap Sass implementation #607

Closed
wants to merge 1 commit into from
Closed

Now using official Bootstrap Sass implementation #607

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 7, 2014

Ok, that was a lot easier than I expected. ;) Tested this out, ran grunt serve, all looks good! Not sure if I should've done any more in-depth testing than that. I'm not 100% familiar with the inner workings of yo/grunt/bower.

@ghost
Copy link
Author

ghost commented Mar 7, 2014

PS: I didn't update the CHANGELOG. Not sure if I'm supposed to or not.

@eddiemonge
Copy link
Member

how many official sass bootstraps are there? jeez

@ghost
Copy link
Author

ghost commented Mar 7, 2014

Tell me about it. The repository needs to be cleaned up, big time. There's one package called bootstrap-sass but that points to github.com/jlong/sass-twitter-bootstrap.git which is not the official package.

bootstrap-sass-official is the real deal (github.com/twbs/bootstrap-sass.git).

@eddiemonge
Copy link
Member

you dont update the changelog, that happens automatically based on the commit message as long as you follow the Contributing guidelines for the project

@eddiemonge eddiemonge closed this in 66829f4 Mar 7, 2014
@ghost
Copy link
Author

ghost commented Mar 7, 2014

Why was this not merged?

@eddiemonge
Copy link
Member

it was merged in 66829f4

@ghost
Copy link
Author

ghost commented Mar 7, 2014

Ah ok, thanks

@eddiemonge
Copy link
Member

no, thank you for letting us know about the issue. most of the team don't dev on windows machines so we often don't know when there are windows specific issues

@ghost
Copy link
Author

ghost commented Mar 8, 2014

Oh it's not a Windows or platform specific issue. I'm actually on Mac OS 10.8. I just realized that Bootstrap 3.1 officially supported Sass, and all the yeoman generators (angular, webapp, etc) were still using the 3rd party Bootstrap/Sass ports. :) So I wanted to fix them to use the official Bootstrap 3.1.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant