You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi, I've got <1 day experience with your library, but it's looking good so far!
I quickly catapulted a project together today for our system [we get raw AIS bytes, so I'm side-stepping the NMEA sentence parsing] and noticed that it seems possible to chuck invalid messages at it - e.g. a Message type 5 with only 2 bytes.
With many (all?) of the AIS message types being defined as a fixed numbers of bits, I was wondering if AisParser should throw if the Payload is too short (or too long) for the message type indicated by the first byte?
I've only been reading AIS spec for a couple of weeks, so apologies if I've over-simplified, but just looking to ensure catching rogue/corner cases in our code too.
'For discussion', not a criticism ;)
The text was updated successfully, but these errors were encountered:
Hi, I've got <1 day experience with your library, but it's looking good so far!
I quickly catapulted a project together today for our system [we get raw AIS bytes, so I'm side-stepping the NMEA sentence parsing] and noticed that it seems possible to chuck invalid messages at it - e.g. a Message type 5 with only 2 bytes.
With many (all?) of the AIS message types being defined as a fixed numbers of bits, I was wondering if AisParser should throw if the Payload is too short (or too long) for the message type indicated by the first byte?
I've only been reading AIS spec for a couple of weeks, so apologies if I've over-simplified, but just looking to ensure catching rogue/corner cases in our code too.
'For discussion', not a criticism ;)
The text was updated successfully, but these errors were encountered: