Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pay attention to the CI checks in a PR #1237

Closed
yegor256 opened this issue Dec 28, 2017 · 3 comments · Fixed by #1653
Closed

pay attention to the CI checks in a PR #1237

yegor256 opened this issue Dec 28, 2017 · 3 comments · Fixed by #1653
Assignees
@volodya-lombrozo
Milestone
next

Comments

@yegor256
Copy link
Owner

Let's fail the merge if any CI checks are reporting failures. This feature should be configurable from .rultor.yml and turned ON by default.
@filfreire
Copy link
Contributor

@yegor256 I'll tackle this.

@yegor256 yegor256 added this to the next milestone Nov 7, 2022
@yegor256 yegor256 mentioned this issue Mar 1, 2023
Merged
@volodya-lombrozo
Copy link
Contributor

volodya-lombrozo commented Mar 1, 2023 •
edited
Loading

@yegor256 I might take care of it. Could you assign it to me, please?

@yegor256
Copy link
Owner Author

yegor256 commented Mar 1, 2023

@volodya-lombrozo go ahead pls

@volodya-lombrozo volodya-lombrozo mentioned this issue Mar 3, 2023
Merged
volodya-lombrozo added a commit to volodya-lombrozo/rultor that referenced this issue Mar 4, 2023
@volodya-lombrozo
feat(yegor256#1237): ressurect QnMergeTest
e3c5d6b
@volodya-lombrozo volodya-lombrozo mentioned this issue Mar 4, 2023
Merged
volodya-lombrozo added a commit to volodya-lombrozo/rultor that referenced this issue Mar 5, 2023
@volodya-lombrozo
feat(yegor256#1237): ressurect QnMergeTest
9410343
volodya-lombrozo added a commit to volodya-lombrozo/rultor that referenced this issue Mar 5, 2023
@volodya-lombrozo
fix(yegor256#1237): change minify phase to prepare-package
7cd9e07
volodya-lombrozo added a commit to volodya-lombrozo/rultor that referenced this issue Mar 10, 2023
@volodya-lombrozo
feat(yegor256#1237): add more informative message
41c2575
volodya-lombrozo added a commit to volodya-lombrozo/rultor that referenced this issue Mar 22, 2023
@volodya-lombrozo
feat(yegor256#1237): Verify pull request check runs before merging ch…
620d707 
…anges
@volodya-lombrozo volodya-lombrozo mentioned this issue Mar 22, 2023
Merged
volodya-lombrozo added a commit to volodya-lombrozo/rultor that referenced this issue Mar 23, 2023
@volodya-lombrozo
feat(yegor256#1237): update jcabi-github version
c77f016
volodya-lombrozo added a commit to volodya-lombrozo/rultor that referenced this issue Mar 23, 2023
@volodya-lombrozo
feat(yegor256#1237): refresh code accoding with qulice suggestions
486a74e
volodya-lombrozo added a commit to volodya-lombrozo/rultor that referenced this issue Mar 23, 2023
@volodya-lombrozo
feat(yegor256#1237): refresh code accoding with qulice suggestions
7c083c0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@volodya-lombrozo volodya-lombrozo

Labels
None yet
Projects
None yet
Milestone
next
Development

Successfully merging a pull request may close this issue.

feat(#1237): verify Pull Requests Check Runs before merging volodya-lombrozo/rultor
3 participants
@yegor256 @filfreire @volodya-lombrozo