#1906 typo

yegor256 · Mar 1, 2024 · a836d9e · a836d9e
1 parent efa96a1
commit a836d9e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/src/main/java/com/rultor/agents/aws/PingsInstance.java b/src/main/java/com/rultor/agents/aws/PingsInstance.java
@@ -63,6 +63,7 @@ public PingsInstance() {
     @Override
     @SuppressWarnings("PMD.AvoidCatchingGenericException")
     public Iterable<Directive> process(final XML xml) throws IOException {
+        final String name = xml.xpath("/talk/@name").get(0);
         final Shell shell = new TalkShells(xml).get();
         final String instance = xml.xpath("/talk/ec2/instance/text()").get(0);
         final String host = xml.xpath("/talk/shell/host/text()").get(0);
@@ -73,19 +74,23 @@ public Iterable<Directive> process(final XML xml) throws IOException {
                 new Shell.Empty(new Shell.Safe(shell)).exec("whoami");
                 Logger.warn(
                     this, "AWS instance %s is alive at %s for %s",
-                    instance, host, xml.xpath("/talk/@name").get(0)
+                    instance, host, name
                 );
                 break;
             // @checkstyle IllegalCatchCheck (1 line)
             } catch (final Exception ex) {
                 Logger.warn(
-                    this, "Failed to ping AWS instance %s at %s (attempt no.%d): %s",
-                    instance, host, attempt, ex.getMessage()
+                    this,
+                    "Failed to ping AWS instance %s at %s for %s (attempt no.%d): %s",
+                    instance, host, name, attempt, ex.getMessage()
                 );
                 ++attempt;
                 if (attempt > 5) {
                     dirs.xpath("/talk/daemon").remove();
-                    Logger.warn(this, "The AWS instance %s is officially dead", instance);
+                    Logger.warn(
+                        this, "The AWS instance %s is officially dead at %s",
+                        instance, name
+                    );
                     break;
                 }
                 new Sleep(1L).now();

diff --git a/src/main/java/com/rultor/agents/aws/ShootsInstance.java b/src/main/java/com/rultor/agents/aws/ShootsInstance.java
@@ -92,6 +92,7 @@ public Iterable<Directive> process(final XML xml) throws IOException {
                     .withInstanceIds(instance)
             );
             Logger.warn(
+                this,
                 "Terminated AWS instance %s because it's %[ms]s old (most probably dead)",
                 instance, age
             );