Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Administrators can see administration list after navigating back to home page #886

Closed
richford opened this issue Oct 15, 2024 · 4 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@richford
Copy link
Contributor

I also noticed that if one returns to administrator home from another route, the administration list is empty.

To reproduce,

  1. Log in as an administrator (e.g. demo-district-admin with password: "password") or super-administrator.
  2. Allow the administration list to load completely
  3. Navigate to another route (e.g. list-orgs or create-administration)
  4. Return to the administrator home (either by clicking on the ROAR logo or on the Administrations > View Administrations menu item).

Expected behavior:

Page displays the same administrations seen in step 2.

@richford
Copy link
Contributor Author

Actual behavior:

Image

@richford richford added the bug Something isn't working label Oct 15, 2024
@richford
Copy link
Contributor Author

This may be related to something I noticed on the participant home page. When a participant first logs in, the "You have no assignments" screen briefly flashes. Then it updates with their assignments. Ideally, we would wait until we have retrieved their assignments before assessing whether to show the "You have no assignments" screen. I didn't make an issue of that one because I believe it exists on prod and was not introduced by @maximilianoertel's PR.

However, is it possible that the same thing is happening to administrators and that the dashboard is using the cached "no administrations" result to display the list of administrations?

@maximilianoertel
Copy link
Collaborator

maximilianoertel commented Oct 15, 2024

I noticed that as well and have been looking into it, but the participant homepage is a bit more complex than the administrator homepage. The PR for the latter is ready for review and I hope to have a fix for the participant homepage ready shortly!

@maximilianoertel
Copy link
Collaborator

@richford the Participant homepage loading state issue should get resolved with #889

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants