fix: only forbid endpoint, not function #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Agustín Ramiro Díaz <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #839 +/- ##
=======================================
Coverage 16.79% 16.79%
=======================================
Files 124 124
Lines 9856 9856
Branches 248 248
=======================================
Hits 1655 1655
Misses 8116 8116
Partials 85 85 ☔ View full report in Codecov by Sentry. |
|
kstroobants
approved these changes
Jan 22, 2025
|
🎉 This PR is included in version 0.34.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #838
What
Only fixes the issue's problem
Why
I am using VALIDATORS_CONFIG_JSON and I need it
Testing done
Tested changing VALIDATORS_CONFIG_JSON and it works
Decisions made
We should probably do this with all of the functions
I think there's a problem with the current model: we have mixed our domain logic and our endpoints logic
I think it'd be nice if we were able to extract the logic into it's own module, and then import it from the flask server and expose what we want
Obviously this is a larger issue what I'm fixing here
Checks
Reviewing tips
User facing release notes
Fix bug with
VALIDATORS_CONFIG_JSON