Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: appeals add validators when appealed #603

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

feat: appeals add validators when appealed #603

wants to merge 9 commits into from

Conversation

kstroobants
Copy link
Contributor

@kstroobants kstroobants commented Nov 15, 2024 •
edited
Loading

Fixes #593

What

  • Implemented issue description
  • Refactored consensus flow into state classes and added a transaction_context that contains data that is useful for other states the transaction will go to and it is not in the database. The reason is to perform loops in the consensus with structured code.
  • Added class methods to convert dicts to objects. This is needed because an accepted transaction that is appealed needs to be validated by genvm. The genvm accepts only objects (like transaction.consensus_data.leader_receipt.eq_outputs).
  • Added tests.

Why

  • To add more value to the user

Testing done

  • Tested the new feature by adding tests to test_base.py
  • Simulated it in the simulator

Checks

  • I have tested this code
  • I have reviewed my own PR
  • I have created an issue for this PR
  • I have set a descriptive PR title compliant with conventional commits

Reviewing tips

Run test_base.py + play around in the simulator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Appeals: add validators when appealed
1 participant
@kstroobants