-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow configuring validators from envvar #585
feat: allow configuring validators from envvar #585
Conversation
Signed-off-by: Agustín Ramiro Díaz <[email protected]>
Signed-off-by: Agustín Ramiro Díaz <[email protected]>
Signed-off-by: Agustín Ramiro Díaz <[email protected]>
Signed-off-by: Agustín Ramiro Díaz <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #585 +/- ##
=======================================
Coverage 17.78% 17.78%
=======================================
Files 122 122
Lines 9558 9558
Branches 283 283
=======================================
Hits 1700 1700
Misses 7775 7775
Partials 83 83 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Agustín Ramiro Díaz <[email protected]>
Signed-off-by: Agustín Ramiro Díaz <[email protected]>
Quality Gate failedFailed conditions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e2e tests were broken prior to this PR
🎉 This PR is included in version 0.19.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Fixes #567
What
Allows configuring validators from the envvar
VALIDATORS_CONFIG_JSON
Why
To make deployment easier
Testing done
VALIDATORS_CONFIG_JSON = '[{"stake": 100, "provider": "openai", "model": "gpt-4o", "amount": 2}]'
andVALIDATORS_CONFIG_JSON = ''
Decisions made
Checks
Reviewing tips
Read unit tests first to understand the behavior
Extra
Maybe this feature is useful in the genlayer CLI? @denishacquin @cristiam86
User facing release notes
Now you can easily start up your validators from the envvar
VALIDATORS_CONFIG_JSON