Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide methods during deployment to avoid pointing to the wrong contract instance #582

Conversation

denishacquin
Copy link
Contributor

@denishacquin denishacquin commented Nov 5, 2024

Fixes #495

What

  • Fixed the issue by removing deployed contract from store on deploy, effectively hiding methods UI when a new deployment is triggered
  • Improved "new deployment" button icon/copy for clarity:
image

Why

  • to fix a bug
  • to improve UX

Testing done

  • tested the bug fix
  • frontend e2e ok
  • frontend unit ok

Decisions made

  • Decided to improve some copy

Checks

  • I have tested this code
  • I have reviewed my own PR
  • I have created an issue for this PR
  • I have set a descriptive PR title compliant with conventional commits

Reviewing tips

  • Validate that the copy makes sense for the button

User facing release notes

  • Fixed an issue with contract method not pointing to the correct contract instance during deployment

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 17.78%. Comparing base (19cc640) to head (948a7c9).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
frontend/src/components/Simulator/ContractInfo.vue 0.00% 3 Missing ⚠️
frontend/src/hooks/useContractQueries.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #582      +/-   ##
==========================================
- Coverage   17.78%   17.78%   -0.01%     
==========================================
  Files         122      122              
  Lines        9558     9560       +2     
  Branches      283      283              
==========================================
  Hits         1700     1700              
- Misses       7775     7777       +2     
  Partials       83       83              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Nov 5, 2024

@denishacquin denishacquin changed the title 495 sim fe calling contract prior to its deployment points to previous contract fix: hide methods during deployment to avoid pointing to the wrong contract instance Nov 5, 2024
@denishacquin denishacquin marked this pull request as ready for review November 5, 2024 06:09
@denishacquin denishacquin merged commit 4f1f948 into main Nov 14, 2024
19 of 28 checks passed
@denishacquin denishacquin deleted the 495-sim-fe-calling-contract-prior-to-its-deployment-points-to-previous-contract branch November 14, 2024 06:06
Copy link
Contributor

🎉 This PR is included in version 0.20.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SIM-FE- Calling contract prior to its deployment points to previous contract
2 participants