feat: migrate to new calldata #565
Conversation
- add parser for ts - add encoder for ts - bring python implementation from genvm - patch backend for working with binary calldata
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #565 +/- ##
==========================================
+ Coverage 15.35% 19.60% +4.24%
==========================================
Files 112 116 +4
Lines 7950 8403 +453
Branches 187 274 +87
==========================================
+ Hits 1221 1647 +426
- Misses 6653 6680 +27
Partials 76 76 ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
frontend/src/calldata/parser.ts
Outdated
| [true, /^,/g, TokenKind.Comma], | ||
| [true, /^:/g, TokenKind.Colon], | ||
| [true, /^(?!\d)\w\w*/g, TokenKind.Id], | ||
| [true, /^'(?:[^']|\\.)*'/g, TokenKind.Str], |
Check failure
Code scanning / CodeQL
Inefficient regular expression High
frontend/src/calldata/parser.ts
Outdated
| [true, /^:/g, TokenKind.Colon], | ||
| [true, /^(?!\d)\w\w*/g, TokenKind.Id], | ||
| [true, /^'(?:[^']|\\.)*'/g, TokenKind.Str], | ||
| [true, /^"(?:[^"]|\\.)*"/g, TokenKind.Str], |
Check failure
Code scanning / CodeQL
Inefficient regular expression High
| @@ -42,6 +43,24 @@ def _parse_transaction_data(transaction_data: Transactions) -> dict: | |||
| ], | |||
| } | |||
|
|
|||
| @staticmethod | |||
| def _transaction_data_to_str(data: dict) -> str: | |||
| """ | |||
There was a problem hiding this comment.
@AgustinRamiroDiaz comment added
|
Actually I found out that probably what we mean by address is 20 bytes and not 32 as in this PR. It is sort of confusing:
If I fix that right now, will it break js sdk? @cristiam86 |
The JS SDK does exactly the same as the simulator front-end so I will adapt it |
kp2pml30
force-pushed
the
migrate-to-new-calldata
branch
from
ce8eb0f
to
bc69b4a
Compare
|
🎉 This PR is included in version 0.18.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Fixes <no issue>
What
Why
Testing done
Decisions made
Checks
Reviewing tips
For now there is a problem with "json" input by user for obvious reasons. I can allocate some time to fix them, but I am not great in reactive ui's
User facing release notes
New calldata string representation is slightly different from json:
b#<hex bytes>)addr#<64 hex digits>"