-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Make sample type
an Auspice filter
#228
Comments
@jmcbroome would this be easy to add? |
I'm afraid I'm lacking some context for this request. We don't use an "Auspice_config" json, we have a simple Nextstrain json format hardcoded into matUtils. Would "sample type" be some kind of metadata tagging that we could set a coloring by, similar to country? How would "sample type" be determined? Would this be part of an output from calling an UShER placement, and the samples would be tagged by whether they were added in that call? |
Happy to explain @jmcbroome :) You already have it as a color by: All that's needed is to add a little bit of code to the hardcoded auspice.json part here: usher/src/matUtils/convert.cpp Line 481 in 728b739
I'll see what needs to be added to get it to work - it should just be a very small code change. |
Here's an auspice config.json I found in this repo. Not sure whether it's used at all. https://github.com/yatisht/usher/blob/master/workflows/config/config.json |
@jmcbroome what I don't understand is why the The weird thing is, that I can only find a description mentioning usher/src/matUtils/convert.cpp Line 474 in a37da00
@AngieHinrichs do you have an idea where the web version of auspice meta comes from? |
I think it would be nice to have
sample type
enabled as an Auspice filter.It should be as easy as adding a few lines to the auspice_config.json that's used for exporting.
That way, one could quickly filter down to new samples as opposed to reference tree samples.
The text was updated successfully, but these errors were encountered: