Add support for strict-ssl config #1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @TAGraves! It looks like this diff fails lint due to some Flow errors: https://travis-ci.org/yarnpkg/yarn/jobs/167763999. Could you please fix those? Thank you! 😄 |
|
@Daniel15 Sorry about that! I've fixed the errors, thanks! |
sebmck
reviewed
Oct 15, 2016
| // value if it exists | ||
| if (!val || val === DEFAULTS[key]) { | ||
| val = this.registries.npm.getOption(key) || val; | ||
| // if this isn't set in a yarn config, then use npm |
There was a problem hiding this comment.
Can you please remove this commit from the PR, happy to accept the other option but I have problems with this code that I'll address in your other PR.
There was a problem hiding this comment.
Nevermind, this seems fine. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for setting
strict-ssltofalsein npm config or in.yarnrc. The reason behind adding this support is to enable users of private registries with self-signed TLS certificates to use yarn.I believe this is all that is needed to enable such support, but let me know if I have overlooked something. Also, let me know if some tests should be written for this feature.
This is dependent on #1024, as
strict-sslis a boolean option and it is impossible to set tofalsewithout 1024's fix.