Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove junk from dist #908

Closed
Daniel15 opened this issue Oct 12, 2016 · 4 comments
Closed

Remove junk from dist #908

Daniel15 opened this issue Oct 12, 2016 · 4 comments
Assignees

Comments

@Daniel15
Copy link
Member

There's a bunch of files in dist that we don't actually need, mainly readmes and examples from third-party modules. This unnecessarily bloats out the download size. I already had to clean up some of them to avoid lint errors in the Debian package (https://github.com/yarnpkg/yarn/blob/master/scripts/build-deb.sh#L45-L47) but we should try to clean up other stuff where possible.

@Daniel15
Copy link
Member Author

There's ~2.3 MB of files in node_modules\rx\ts we probably don't need

@jamiebuilds
Copy link
Contributor

Here's a fun idea, you could use module-deps to find all the things that are actually necessary to run Yarn and only copy those files into dist

@Daniel15
Copy link
Member Author

Daniel15 commented Nov 14, 2016

That's an interesting idea. We do have the standalone .js file built using Webpack, I wonder if we can get Webpack to output the dependency tree in a similar way and use that.

We do need to keep the LICENSE files, so we should be sure to special-case those regardless of the approach we take 😄

@Daniel15
Copy link
Member Author

Not needed now that we have a flat bundle (#3030)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants