Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optionalDependencies are not optional #844

Closed
3LOK opened this issue Oct 12, 2016 · 1 comment
Closed

optionalDependencies are not optional #844

3LOK opened this issue Oct 12, 2016 · 1 comment

Comments

@3LOK
Copy link

3LOK commented Oct 12, 2016

Do you want to request a feature or report a bug?
Feature

What is the current behavior?
I've read you don't really support optionalDependencies (for the deterministic feature). We use this heavily with our CI so our CI can use internal tools for publishing packages, while allowing public usage of the published package.

Is there any plan on solving this issue, or will optionalDependencies never be really optional in Yarn?

Note: --ignore-optional doesn't work as well, as you can see here:

yarn add redux-saga-tester --ignore-optional

If the current behavior is a bug, please provide the steps to reproduce.
Create a package.json file, add one of the following to it:

  "optionalDependencies":{
     "unknown-package-9999":"*"
  }

or

  "optionalDependencies":{
     "@wix/wnpm-ci":"*"
  }

What is the expected behavior?
As described here:

If a dependency can be used, but you would like npm to proceed if it cannot be found or fails to install, then you may put it in the optionalDependencies object

Gracefully continue installing other packages, and succeed if the others succeed.

Please mention your node.js, yarn and operating system version.
Node v6.2.0
Yarn v0.15.1
OSX 10.11.2

@sebmck
Copy link
Contributor

sebmck commented Oct 12, 2016

Fixed via #789.

@sebmck sebmck closed this as completed Oct 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants