In Yarn Workspaces, sub dependency .bin symlinks can override top level dependency .bin symlink #6300
Assignees
Labels
Comments
ghost
assigned 
|
@torifat |
|
@torifat any updates here? |
|
Maybe @arcanis you can take a look it looks like torifat hasn't had a chance to look at a bunch of issues. I am glad to help with this issue and file a PR if i could get some guidance on where the issue might be and where to start. |
tiffon
added a commit
to jaegertracing/jaeger-ui
that referenced
this issue
Jan 7, 2019
Avoid issue yarnpkg/yarn#6300 Signed-off-by: Joe Farro <[email protected]>
tiffon
added a commit
to jaegertracing/jaeger-ui
that referenced
this issue
Jan 9, 2019
* WIP upgrade to create-react-app v2.1.2 Requires changes from PR #346 which are published as [email protected] timarney/react-app-rewired#346 Signed-off-by: Joe Farro <[email protected]> * Use node 8, less liberal browser support, fix test Signed-off-by: Joe Farro <[email protected]> * Use eslintrc, fix CI build, fix pre-commit hook Make sure the ./packages/jaeger-ui uses the ./.eslintrc. Make sure all tests are run in pre-commit hook. CRA is now failing builds in CI if there are any webpack build warnings: https://github.com/facebook/create-react-app/blob/73e3d0ebf1f2834e1c8c41d3a25ae5e0e99e6f14/packages/react-scripts/scripts/build.js#L171-L184 Signed-off-by: Joe Farro <[email protected]> * Skip react-vis.css format check, fail-fast in CI Signed-off-by: Joe Farro <[email protected]> * Don't collect coverage from dev proxy setup Signed-off-by: Joe Farro <[email protected]> * Upgrade react-app-rewired to 2.0.1 Avoid issue yarnpkg/yarn#6300 Signed-off-by: Joe Farro <[email protected]> * Cleanup npm packages in packages/jaeger-ui Signed-off-by: Joe Farro <[email protected]>
everett980
pushed a commit
to everett980/jaeger-ui
that referenced
this issue
Jan 16, 2019
* WIP upgrade to create-react-app v2.1.2 Requires changes from PR jaegertracing#346 which are published as [email protected] timarney/react-app-rewired#346 Signed-off-by: Joe Farro <[email protected]> * Use node 8, less liberal browser support, fix test Signed-off-by: Joe Farro <[email protected]> * Use eslintrc, fix CI build, fix pre-commit hook Make sure the ./packages/jaeger-ui uses the ./.eslintrc. Make sure all tests are run in pre-commit hook. CRA is now failing builds in CI if there are any webpack build warnings: https://github.com/facebook/create-react-app/blob/73e3d0ebf1f2834e1c8c41d3a25ae5e0e99e6f14/packages/react-scripts/scripts/build.js#L171-L184 Signed-off-by: Joe Farro <[email protected]> * Skip react-vis.css format check, fail-fast in CI Signed-off-by: Joe Farro <[email protected]> * Don't collect coverage from dev proxy setup Signed-off-by: Joe Farro <[email protected]> * Upgrade react-app-rewired to 2.0.1 Avoid issue yarnpkg/yarn#6300 Signed-off-by: Joe Farro <[email protected]> * Cleanup npm packages in packages/jaeger-ui Signed-off-by: Joe Farro <[email protected]> Signed-off-by: Everett Ross <[email protected]>
|
Created my own demo of this before coming across this issue: https://github.com/ndreckshage/yarn-workspace-bin-issue In my example:
This is still an issue in |
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this issue
Jul 5, 2021
* WIP upgrade to create-react-app v2.1.2 Requires changes from PR jaegertracing#346 which are published as [email protected] timarney/react-app-rewired#346 Signed-off-by: Joe Farro <[email protected]> * Use node 8, less liberal browser support, fix test Signed-off-by: Joe Farro <[email protected]> * Use eslintrc, fix CI build, fix pre-commit hook Make sure the ./packages/jaeger-ui uses the ./.eslintrc. Make sure all tests are run in pre-commit hook. CRA is now failing builds in CI if there are any webpack build warnings: https://github.com/facebook/create-react-app/blob/73e3d0ebf1f2834e1c8c41d3a25ae5e0e99e6f14/packages/react-scripts/scripts/build.js#L171-L184 Signed-off-by: Joe Farro <[email protected]> * Skip react-vis.css format check, fail-fast in CI Signed-off-by: Joe Farro <[email protected]> * Don't collect coverage from dev proxy setup Signed-off-by: Joe Farro <[email protected]> * Upgrade react-app-rewired to 2.0.1 Avoid issue yarnpkg/yarn#6300 Signed-off-by: Joe Farro <[email protected]> * Cleanup npm packages in packages/jaeger-ui Signed-off-by: Joe Farro <[email protected]> Signed-off-by: vvvprabhakar <[email protected]>
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this issue
Jul 5, 2021
* WIP upgrade to create-react-app v2.1.2 Requires changes from PR jaegertracing#346 which are published as [email protected] timarney/react-app-rewired#346 Signed-off-by: Joe Farro <[email protected]> * Use node 8, less liberal browser support, fix test Signed-off-by: Joe Farro <[email protected]> * Use eslintrc, fix CI build, fix pre-commit hook Make sure the ./packages/jaeger-ui uses the ./.eslintrc. Make sure all tests are run in pre-commit hook. CRA is now failing builds in CI if there are any webpack build warnings: https://github.com/facebook/create-react-app/blob/73e3d0ebf1f2834e1c8c41d3a25ae5e0e99e6f14/packages/react-scripts/scripts/build.js#L171-L184 Signed-off-by: Joe Farro <[email protected]> * Skip react-vis.css format check, fail-fast in CI Signed-off-by: Joe Farro <[email protected]> * Don't collect coverage from dev proxy setup Signed-off-by: Joe Farro <[email protected]> * Upgrade react-app-rewired to 2.0.1 Avoid issue yarnpkg/yarn#6300 Signed-off-by: Joe Farro <[email protected]> * Cleanup npm packages in packages/jaeger-ui Signed-off-by: Joe Farro <[email protected]> Signed-off-by: Everett Ross <[email protected]> Signed-off-by: vvvprabhakar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Do you want to request a feature or report a bug?
Bug
What is the current behavior?
When using yarn workspaces. Sub dependencies .bin symlinks override top level dependencies .bin symlinks.
NOTE this was fixed in non workspaces with #4937
If the current behavior is a bug, please provide the steps to reproduce.
Example: https://github.com/mlavina/yarn-symlink-bug
What is the expected behavior?
Please mention your node.js, yarn and operating system version.
Node: 8.9.1
Yarn: 1.9.4
OS: Windows 7
Tagging @anders-advisa and @rally25rs Since they worked on the similar bug mentioned above
The text was updated successfully, but these errors were encountered: