yarn import fails whenfsevents is an optional dependency and platform is linux

[tvjg]

Do you want to request a feature or report a bug?

Report a bug

What is the current behavior?

yarn import fails when a package has fsevents included as an optional transitive dependency. Using --ignore-optional does not appear to change the behavior.

┌[vagrant@host]─[~/repro-case]─[]
└[$]› yarn import
yarn import v1.7.0
info found npm package-lock.json, converting to yarn.lock
⠄ [email protected]
name: fsevents
parentNames: [ 'eslint-watch', 'chokidar' ]
error An unexpected error occurred: "Cannot read property 'version' of undefined".
info If you think this is a bug, please open a bug report with the information provided in "/home/vagrant/repro-case/yarn-error.log".


info Visit https://yarnpkg.com/en/docs/cli/import for documentation about this command.

Originally, this failed without any useful output, but I inserted some log statements into cli.js to identify the source of the failure. Interestingly, if I remove package-lock.json, the import works successfully against node_modules/, but produces a warning.

┌[vagrant@host]─[~/repro-case]─[]
└[$]› yarn import
yarn import v1.7.0
info creating yarn.lock from local node_modules folder
success Folder in sync.
warning Import of "eslint-watch@^3.1.4" for "test_web" failed, resolving normally.
info [email protected]: The platform "linux" is incompatible with this module.
info "[email protected]" is an optional dependency and failed compatibility check. Excluding it from installation.
warning " > [email protected]" has unmet peer dependency "eslint@>=0.19.0 <5.0.0".
success Saved lockfile.
Done in 5.79s.

If the current behavior is a bug, please provide the steps to reproduce.

Run yarn import against the included package-lock.json. You should receive the error:

 An unexpected error occurred: "Cannot read property 'version' of undefined".

yarn-error.log

It would appear to have some relation to #5930, #6040, and #5366 .

What is the expected behavior?

yarn should generate a yarn.lock file.

Please mention your node.js, yarn and operating system version.

┌[vagrant@host]─[~/repro-case]─[]
└[$]› node -v
v6.9.0

┌[vagrant@host]─[~/repro-case]─[]
└[$]› yarn -v
1.7.0

┌[vagrant@host]─[~/repro-case]─[]
└[$]› cat /etc/*release
CentOS release 6.6 (Final)

[rally25rs]

@imsnif any ideas on this?

[imsnif]

Interesting. AFAIK, (transitive) optional dependencies should still be included in package-lock.json - I might be wrong though (that's what happens for me locally, but the particularities here might be different).

It seems like in this package-lock.json the [email protected] package entry does not include the fsevents dependency, and so it is not included at all in the package-lock.json file. This is likely what's causing the issue.

@tvjg - would it be possible for you to include your package.json as well? That way we can check this out and know for certain (as well as come up with a holistic solution).

Meanwhile, I think if you remove node_modules and then npm install eslint-watch it should fix the package-lock.json file and then you'd be able to yarn import without issue. I'll be able to know for certain (and know where this problem likely came from) if I have access to the package.json file.

[imsnif]

(also, thanks @tvjg for the debugging work, it was quite helpful)

[tvjg]

Happy to contribute @iansu . I deleted the original repro case I had, but I was able to easily duplicate it again.

┌[vagrant@host]─[~/repro-case]─[]
└[$]› cat package.json 
{
  "name": "repro-case",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "author": "",
  "license": "ISC",
  "devDependencies": {
    "eslint-watch": "^4.0.2"
  }
}

[imsnif]

Hey @tvjg - so this package-lock.json file is definitely missing some deps. Good news is that it's totally fixable. This worked for me locally:

1. Run npm install in the project's folder - this will update the package-lock.json with the missing deps.
2. Run yarn import

Hope this helps, I'm closing this issue now - but let me know if it doesn't work out and I'll look into it.

[tvjg]

It appears to still be broken. Thinking that maybe I messed up recreating the file, I tried starting over from scratch with that package.json.

1. npm install
2. Confirm package-lock.json is generated
3. yarn import
4. Observe failure
5. npm install
6. yarn import
7. Observe failure again

[imsnif]

@tvjg - which version of npm are you using to install?

[tvjg]

┌[vagrant@host]─[~/repro-case]─[]
└[$]› npm -v
5.1.0

[imsnif]

I think that's the issue. Older versions of npm (iirc pre 6.1 but don't take my word for it!) did not place unsupported optional dependencies in package-lock.json. If you upgrade npm to the latest version (npm install -g npm) and then repeat the process (update the lockfile with npm install and then import) it should do the trick.

[imsnif]

@kpower - even if you npm install with 6.4.1 before? Is fsevents in your package-lock.json?

[kpower]

@imsnif sorry, the problem was on my shared hosting side (a bit later noticed it started display random errors during other tasks). No problems now (deleted original comment).