Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrupted node_modules/.bin/gulp.cmd after yarn install #3350

Closed
farrago opened this issue May 8, 2017 · 9 comments
Closed

Corrupted node_modules/.bin/gulp.cmd after yarn install #3350

farrago opened this issue May 8, 2017 · 9 comments

Comments

@farrago
Copy link

farrago commented May 8, 2017

What is the current behavior?

yarn install with https://github.com/zurb/foundation-emails-template ends up with garbage characters in node_modules/.bin/gulp.cmd.

This appears to be exactly as described in #828.
#828 was closed fixed based on PR2795, but in the comments on that PR you can find a number of comments that this does not entirely fix the problem. In that thread of comments PR3097 is proposed as a solution but hasn't been merged yet.

If the current behavior is a bug, please provide the steps to reproduce.
See #828 or

  1. Clone https://github.com/zurb/foundation-emails-template
  2. yarn install
  3. gulp <-- fails

View node_modules/.bin/gulp.cmd and see corruption as described in #828

What is the expected behavior?
It should not corrupt gulp.cmd

Please mention your node.js, yarn and operating system version.

  • node.js: v4.8.1
  • yarn: 0.23.4
  • OS: Windows 10
@OwnerOfThisIsle
Copy link

Same here with yarn 0.24.6.
After freshly installing karma the binary karma.cmd ends with garbage characters.
Not every time, but roughly every forth time, my CI is really unstable that way..

OS: Windows 7

@BrianVallelunga
Copy link

We're also seeing this behavior on AppVeyor with build 0.24.6 and it is extremely annoying. Is there a temporary workaround that anyone has found?

@stogle
Copy link

stogle commented Aug 30, 2017

The simplest workaround is to npm install the corrupted package.

@farrago
Copy link
Author

farrago commented Aug 30, 2017

To be honest, since NPM 5 introduced package-lock.json, my "workaround" has just been to move back to npm completely. It is still slightly slower, but now has broadly equivalent capabilities and most importantly it consistently works.

@BYK
Copy link
Member

BYK commented Oct 27, 2017

This was fixed in a recent version of Yarn so closing.

@BYK BYK closed this as completed Oct 27, 2017
@BYK
Copy link
Member

BYK commented Oct 27, 2017

Also, @farrago, that is not really a useful comment for this issue. I'm happy that you are happy with npm5 since it has gotten much better but these kinds of comments neither help npm nor helps us resolve the issue.

@farrago
Copy link
Author

farrago commented Oct 27, 2017

Hi @BYK, glad it's fixed and look forward to testing it.

My comment was simply aimed at helping @BrianVallelunga who specifically asked for a workaround (to the issue that I had opened). If someone had provided a workaround within Yarn then I obviously wouldn't have commented regarding using npm. Sadly, I don't believe there was a workaround within yarn at the time.

For the future, do you have a code of conduct or similar which includes what is or isn't recommended for including in comments on this project? I know OS maintenance is a thankless task, so I'm thankful for all the effort people put into it, and I'm happy to only add comments in a way that the team feels is helpful.

@BrianVallelunga
Copy link

Well, I'm happy it is closed. What release is this fixed in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants