Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarn add <npm-package> rewrites bower.json even though nothing was added. #1193

Closed
kitsunde opened this issue Oct 18, 2016 · 5 comments
Closed

Comments

@kitsunde
Copy link

kitsunde commented Oct 18, 2016

Do you want to request a feature or report a bug?

bug

What is the current behavior?

If I have a bower.json that isn't ordered. Like:

{
  "name": "patontheback",
  "dependencies": {
    "animate.css": "3.5.2",
    "Faker": "3.1.0"
  }
}

Then do:

yarn add node-sass

It will rewrite bower.json into being ordered:

{
  "name": "patontheback",
  "dependencies": {
    "Faker": "3.1.0",
    "animate.css": "3.5.2"
  }
}

What is the expected behavior?

If it's not doing stuff to bower.json it should probably just leave it alone.

Please mention your node.js, yarn and operating system version.

$ yarn --version
0.15.1
$ node --version
v6.8.1
$ sw_vers -productVersion
10.12
@hawkrives
Copy link

If I have a bower.json that isn't ordered.

If you have that file, what does Yarn do to it after you run yarn add node-sass?

@kitsunde
Copy link
Author

Sorry hit enter too soon. I've edited it. bower.json gets resaved as an ordered file despite not having any changes.

{
  "name": "patontheback",
  "dependencies": {
    "Faker": "3.1.0",
    "animate.css": "3.5.2"
  }
}

@hawkrives
Copy link

I assume that it does the same thing to a package.json file? Just trying to figure out if it's a bower.json specific thing or not.

@kitsunde
Copy link
Author

@hawkrives Same thing happens with package.json yeah.

@sebmck
Copy link
Contributor

sebmck commented Oct 26, 2016

We've removed support for Bower, see #1441.

@sebmck sebmck closed this as completed Oct 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants