From 94699fb1329a5be2434c2bfa463c812774e522b5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ma=C3=ABl=20Nison?= Date: Tue, 26 Sep 2023 12:46:09 +0200 Subject: [PATCH 1/3] test --- .github/workflows/integration-workflow.yml | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/.github/workflows/integration-workflow.yml b/.github/workflows/integration-workflow.yml index d4a62c8b7ca1..d76cdf2e79b4 100644 --- a/.github/workflows/integration-workflow.yml +++ b/.github/workflows/integration-workflow.yml @@ -201,19 +201,9 @@ jobs: fail-fast: false matrix: # We run the ubuntu tests on multiple Node versions with 2 shards since they're the fastest. - node: [18, 19, 20] + node: [18, 20.6.1, 20.7] platform: [ubuntu-latest] shard: ['1/2', '2/2'] - # We run the rest of the tests on the minimum Node version we support with 3 shards. - include: - # Windows tests - - {node: 18, platform: windows-latest, shard: 1/3} - - {node: 18, platform: windows-latest, shard: 2/3} - - {node: 18, platform: windows-latest, shard: 3/3} - # macOS tests - - {node: 18, platform: macos-latest, shard: 1/3} - - {node: 18, platform: macos-latest, shard: 2/3} - - {node: 18, platform: macos-latest, shard: 3/3} name: '${{matrix.platform}} w/ Node.js ${{matrix.node}}.x (${{matrix.shard}})' runs-on: ${{matrix.platform}} From 62c58e815bef28e4010a610e76e17b97be7ac413 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ma=C3=ABl=20Nison?= Date: Tue, 26 Sep 2023 14:13:39 +0200 Subject: [PATCH 2/3] Updates matrix --- .github/workflows/integration-workflow.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/integration-workflow.yml b/.github/workflows/integration-workflow.yml index d76cdf2e79b4..8e01ee656fd2 100644 --- a/.github/workflows/integration-workflow.yml +++ b/.github/workflows/integration-workflow.yml @@ -201,8 +201,8 @@ jobs: fail-fast: false matrix: # We run the ubuntu tests on multiple Node versions with 2 shards since they're the fastest. - node: [18, 20.6.1, 20.7] - platform: [ubuntu-latest] + node: [18, 20.6, 20.7] + platform: [ubuntu-22.04, ubuntu-20.04] shard: ['1/2', '2/2'] name: '${{matrix.platform}} w/ Node.js ${{matrix.node}}.x (${{matrix.shard}})' From 886ce123d096fe5422ffea6884abc84d1ee3acf7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ma=C3=ABl=20Nison?= Date: Tue, 26 Sep 2023 14:35:27 +0200 Subject: [PATCH 3/3] Disables IO_URING --- .github/workflows/integration-workflow.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/integration-workflow.yml b/.github/workflows/integration-workflow.yml index 8e01ee656fd2..68add3357b95 100644 --- a/.github/workflows/integration-workflow.yml +++ b/.github/workflows/integration-workflow.yml @@ -224,6 +224,8 @@ jobs: - name: 'Run the integration tests' run: | + # https://github.com/nodejs/node/issues/48444 + export UV_USE_IO_URING=0 node ./scripts/run-yarn.js test:integration --maxWorkers=100% --shard=${{matrix.shard}} shell: bash