Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #346
I think there should be at least a little discussion around this change.
In general, this seems very safe. it's effectively only fixing bugs. It doesn't go all the way, though - in bash, the escape sequence with \b looks like this:
where as in this version it'll print out
fixx me
. I'm not sure implementing character deletion makes sense, though - perhaps we could hide actual mutations to the input like this through an option?In general this code path is going to be hit so rarely that I don't think it matters that much. Just think people should be aware of it.
There's also escape sequences like bell which we silently strip out.