Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaks with glimmer (ember 2.10.0) when you don't have a single child element #35

Open
luxzeitlos opened this issue Sep 9, 2016 · 5 comments

Comments

@luxzeitlos
Copy link

I have a ember-tether inside an {{#if}} that contains a {{link-to}}. The following breaks:

  • make the if evaluate to true
  • click the {{link-to}}
  • make the if evaluate to false

I get this error:

Uncaught NotFoundError: Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node.

@juggy
Copy link

juggy commented Oct 14, 2016

I have the problem too, if I can get a pointer where to look, I can help. Any ideas where to start?

@luxzeitlos luxzeitlos changed the title Breaks with glimmer (ember 2.9.0-beta.1) Breaks with glimmer (ember 2.10.0) Nov 30, 2016
@luxzeitlos
Copy link
Author

Okay, I think its far simpler. If the tether is inside an {{#if}} it breaks :/

@luxzeitlos
Copy link
Author

Workaround for now:

Replace this:

{{#if show}}
  {{#ember-tether ...}}...{{/ember-tether}}
{{/if}}

with this:

{{#if show}}
  <div>
  {{#ember-tether ...}}...{{/ember-tether}}
  </div>
{{/if}}

Thanks to this post.

@pzuraq
Copy link

pzuraq commented May 12, 2017

I believe this issue might be solvable using the -in-element helper, which we're using over in ember-popper. It allows you to tell Glimmer to render the block to the target element, so you can render it directly to wherever the Tether would have been appended (body, #ember-application, etc) and Tether won't end up actually moving the element, so Glimmer will know how to remove it later.

@bstro
Copy link

bstro commented Mar 9, 2018

@pzuraq is your suggestion that the -in-element helper be used without Tether, or can you see them being used in parallel? I am a bit unsure as to how I might go about this.

@lukemelia lukemelia changed the title Breaks with glimmer (ember 2.10.0) Breaks with glimmer (ember 2.10.0) when you don't have a single child element Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants