Don't sendAction in click handler when component isDestroying or isDestroyed #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukemelia
approved these changes
Jul 23, 2018
oscarni
force-pushed
the
isdestroying-check
branch
from
db1b779
to
7c7838e
Compare
|
Never mind, I'll leave it as simple as possible. Tried debugging Travis a bit in another branch without luck. |
oscarni
force-pushed
the
isdestroying-check
branch
from
7c7838e
to
a2a0e2e
Compare
oscarni
force-pushed
the
isdestroying-check
branch
from
a2a0e2e
to
2d83a7a
Compare
|
@samselikoff just wanted to let you know that I've rebased and now travis runs without issues ✌️ |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes failed tests since ember 3.2.
Based on tips from this issue emberjs/ember.js#16778