Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I found un-fair data usage #33

Open
mandal4 opened this issue Jan 20, 2020 · 4 comments
Open

I found un-fair data usage #33

mandal4 opened this issue Jan 20, 2020 · 4 comments

Comments

@mandal4
Copy link

mandal4 commented Jan 20, 2020

Hi there.
I well read uploaded source code. I found you set k-shot masked sample with k-'image' not 'instance'.
It might be okay that there is binary mask for input of PRN.
But the same k-'image' is fed into fasterRCNN in 2nd phase. So for FasterRCNN, it could be k+1 shot or k+2 shot and so on because you set k-shot with image-wise.
Unfortunately i think it is un-fair setting for few-shot learning.
Could you explain about it? I hope i misunderstood your nice work.

@mandal4 mandal4 changed the title i found un-fair data usage I found un-fair data usage Jan 20, 2020
@yanxp
Copy link
Owner

yanxp commented Jan 20, 2020

Hello, we have filtered the images with k-shot instance. Please see the function

def filter_class_roidb(roidb, shot, imdb):

@mandal4
Copy link
Author

mandal4 commented Jan 20, 2020

Thanks for reply. I confused that. But still i couldn't understand it is same for input of PRN

@Ze-Yang
Copy link
Contributor

Ze-Yang commented Feb 14, 2020

I have the same concern with you and I have create an issue on the top. Maybe you can check that. I think I express the same idea with you.

@Ze-Yang
Copy link
Contributor

Ze-Yang commented Feb 14, 2020

Hi there.
I well read uploaded source code. I found you set k-shot masked sample with k-'image' not 'instance'.
It might be okay that there is binary mask for input of PRN.
But the same k-'image' is fed into fasterRCNN in 2nd phase. So for FasterRCNN, it could be k+1 shot or k+2 shot and so on because you set k-shot with image-wise.
Unfortunately i think it is un-fair setting for few-shot learning.
Could you explain about it? I hope i misunderstood your nice work.

I also find weird modeling. After the reweighted feature, it also produce num_classes+1 prediction. So what's the contribution of feature reweighting?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants