Do not mark inline functions in JSX as components (fixes #546)

jsx-eslint · Apr 17, 2016 · c1c38eb · c1c38eb
1 parent 68ed8af
commit c1c38eb
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 2 deletions.
diff --git a/lib/util/Components.js b/lib/util/Components.js
@@ -391,7 +391,10 @@ function componentRule(rule, context) {
 
     FunctionExpression: function(node) {
       node = utils.getParentComponent();
-      if (!node) {
+      if (
+        !node ||
+        (node.parent && node.parent.type === 'JSXExpressionContainer')
+      ) {
         return;
       }
       components.add(node, 1);
@@ -407,7 +410,10 @@ function componentRule(rule, context) {
 
     ArrowFunctionExpression: function(node) {
       node = utils.getParentComponent();
-      if (!node) {
+      if (
+        !node ||
+        (node.parent && node.parent.type === 'JSXExpressionContainer')
+      ) {
         return;
       }
       if (node.expression && utils.isReturningJSX(node)) {

diff --git a/tests/lib/rules/prop-types.js b/tests/lib/rules/prop-types.js
@@ -1192,6 +1192,20 @@ ruleTester.run('prop-types', rule, {
         '}'
       ].join('\n'),
       parser: 'babel-eslint'
+    }, {
+      code: [
+        'function Greetings() {',
+        '  return <div>{({name}) => <Hello name={name} />}</div>',
+        '}'
+      ].join('\n'),
+      parser: 'babel-eslint'
+    }, {
+      code: [
+        'function Greetings() {',
+        '  return <div>{function({name}) { return <Hello name={name} />; }}</div>',
+        '}'
+      ].join('\n'),
+      parser: 'babel-eslint'
     }
   ],