Merge pull request #1600 from kevinzwhuang/fix-unused-prop-types

Add empty params check for unused prop types rule to fix empty proptype functions from causing crashes
jsx-eslint · Dec 20, 2017 · 9b8ea5e · 9b8ea5e
2 parents a908eb3 + 6015af2
commit 9b8ea5e
Show file tree

Hide file tree

Showing 2 changed files with 43 additions and 0 deletions.
diff --git a/lib/rules/no-unused-prop-types.js b/lib/rules/no-unused-prop-types.js
@@ -652,6 +652,9 @@ module.exports = {
         case 'ArrowFunctionExpression':
         case 'FunctionDeclaration':
         case 'FunctionExpression':
+          if (node.params.length === 0) {
+            break;
+          }
           type = 'destructuring';
           properties = node.params[0].properties;
           if (inSetStateUpdater()) {

diff --git a/tests/lib/rules/no-unused-prop-types.js b/tests/lib/rules/no-unused-prop-types.js
@@ -2440,6 +2440,46 @@ ruleTester.run('no-unused-prop-types', rule, {
       }
       `,
       parser: 'babel-eslint'
+    },
+    {
+      code: `
+        class MyComponent extends React.Component {
+          render() {
+            return <div>{ this.props.other }</div>
+          }
+        }
+        MyComponent.propTypes = { other: () => {} };
+      `
+    },
+    {
+      code: `
+        class MyComponent extends React.Component {
+          render() {
+            return <div>{ this.props.other }</div>
+          }
+        }
+        MyComponent.propTypes = { other() {} };
+      `
+    },
+    {
+      code: `
+        class MyComponent extends React.Component {
+          render() {
+            return <div>{ this.props.other }</div>
+          }
+        }
+        MyComponent.propTypes = { other: function () {} };
+      `
+    },
+    {
+      code: `
+        class MyComponent extends React.Component {
+          render() {
+            return <div>{ this.props.other }</div>
+          }
+        }
+        MyComponent.propTypes = { * other() {} };
+      `
     }
   ],