Merge pull request #1195 from oliviertassinari/fix

fix: void-dom-elements-no-children
jsx-eslint · May 16, 2017 · 647bcd4 · 647bcd4
2 parents 0dd4685 + 03a8066
commit 647bcd4
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 8 deletions.
diff --git a/lib/rules/void-dom-elements-no-children.js b/lib/rules/void-dom-elements-no-children.js
@@ -110,7 +110,7 @@ module.exports = {
           return;
         }
 
-        if (args.length < 2) {
+        if (args.length < 2 || args[1].type !== 'ObjectExpression') {
           return;
         }
 

diff --git a/tests/lib/rules/void-dom-elements-no-children.js b/tests/lib/rules/void-dom-elements-no-children.js
@@ -53,33 +53,35 @@ ruleTester.run('void-dom-elements-no-children', rule, {
       code: 'document.createElement("img")'
     }, {
       code: 'React.createElement("img");'
+    }, {
+      code: [
+        'const props = {}',
+        'React.createElement("img", props)'
+      ].join('\n')
     }, {
       code: [
         'import React from "react";',
         'const { createElement } = React;',
         'createElement("div")'
-      ].join('\n'),
-      parser: 'babel-eslint'
+      ].join('\n')
     }, {
       code: [
         'import React from "react";',
         'const { createElement } = React;',
         'createElement("img")'
-      ].join('\n'),
-      parser: 'babel-eslint'
+      ].join('\n')
     }, {
       code: [
         'import React, {createElement, PureComponent} from \'react\';',
         'class Button extends PureComponent {',
-        '  handleClick = ev => {',
+        '  handleClick(ev) {',
         '    ev.preventDefault();',
         '  }',
         '  render() {',
         '    return <div onClick={this.handleClick}>Hello</div>;',
         '  }',
         '}'
-      ].join('\n'),
-      parser: 'babel-eslint'
+      ].join('\n')
     }
   ],
   invalid: [