[fix] prefer-stateless-function: avoid crash on ts empty constructor

Fixes #2187
jsx-eslint · Mar 1, 2020 · 5959b5f · 5959b5f
1 parent e231f44
commit 5959b5f
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/lib/rules/prefer-stateless-function.js b/lib/rules/prefer-stateless-function.js
@@ -186,6 +186,7 @@ module.exports = {
         const contextTypes = name === 'contextTypes';
         const defaultProps = name === 'defaultProps';
         const isUselessConstructor = property.kind === 'constructor' &&
+          !!property.value.body &&
           isRedundantSuperCall(property.value.body.body, property.value.params);
         const isRender = name === 'render';
         return !isDisplayName && !isPropTypes && !contextTypes && !defaultProps && !isUselessConstructor && !isRender;

diff --git a/tests/lib/rules/prefer-stateless-function.js b/tests/lib/rules/prefer-stateless-function.js
@@ -157,6 +157,18 @@ ruleTester.run('prefer-stateless-function', rule, {
           }
         }
       `
+    }, {
+      // Issue 2187
+      code: `
+        class Foo extends React.Component {
+          constructor(props)
+
+          render() {
+            return <div>{this.props.foo}</div>;
+          }
+        }
+      `,
+      parser: parsers.TYPESCRIPT_ESLINT
     }, {
       // Use this.bar
       code: `