Fix jsx-handler-names regex (fixes #425)

jsx-eslint · Feb 15, 2016 · 49eedb0 · 49eedb0
1 parent 6643f87
commit 49eedb0
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/lib/rules/jsx-handler-names.js b/lib/rules/jsx-handler-names.js
@@ -15,8 +15,8 @@ module.exports = function(context) {
   var eventHandlerPrefix = configuration.eventHandlerPrefix || 'handle';
   var eventHandlerPropPrefix = configuration.eventHandlerPropPrefix || 'on';
 
-  var EVENT_HANDLER_REGEX = new RegExp('^((props\.' + eventHandlerPropPrefix + ')'
-                                       + '|((.*\.)?' + eventHandlerPrefix + ')).+$');
+  var EVENT_HANDLER_REGEX = new RegExp('^((props\\.' + eventHandlerPropPrefix + ')'
+                                       + '|((.*\\.)?' + eventHandlerPrefix + ')).+$');
   var PROP_EVENT_HANDLER_REGEX = new RegExp('^(' + eventHandlerPropPrefix + '.+|ref)$');
 
   return {

diff --git a/tests/lib/rules/jsx-handler-names.js b/tests/lib/rules/jsx-handler-names.js
@@ -69,6 +69,15 @@ ruleTester.run('jsx-handler-names', rule, {
       '<TestComponent ref={this.somethingRef} />'
     ].join('\n'),
     parserOptions: parserOptions
+  }, {
+    code: [
+      '<TestComponent test={this.props.content} />'
+    ].join('\n'),
+    options: [{
+      eventHandlerPrefix: 'on',
+      eventHandlerPropPrefix: 'on'
+    }],
+    parserOptions: parserOptions
   }],
 
   invalid: [{