Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbms: Fixed misspells in comments #4122

Merged
merged 1 commit into from
Jan 22, 2019

Conversation

maiha
Copy link
Contributor

@maiha maiha commented Jan 22, 2019

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Category (leave one):

  • Bug Fix

Short description (up to few sentences):

  • Fixed misspells in comments and string literals under dbms.
  • Replaced words by using sed commands as follows

Best regards,

s/\bcharater\b/character/g
s/\bchoosen\b/chosen/g
s/\bcomitted\b/committed/g
s/\bcompability\b/compatibility/g
s/\bconatin\b/contain/g
s/\bcongruental\b/congruential/g
s/\bcontinuouty\b/continuity/g
s/\bcorrellation\b/correlation/g
s/\bcoulld\b/could/g
s/\bdictionaeis\b/dictionaries/g
s/\bdisasterous\b/disastrous/g
s/\bdivisable\b/divisible/g
s/\bdo't\b/don't/g
s/\befficently\b/efficiently/g
s/\benogh\b/enough/g
s/\bexcecution\b/execution/g
s/\bexceeeds\b/exceeds/g
s/\bexeption\b/exception/g
s/\bexponentation\b/exponentiation/g
s/\bfolowing\b/following/g
s/\bfuntion\b/function/g
s/\bgemetric\b/geometric/g
s/\bgenreates\b/generates/g
s/\bimmediatly\b/immediately/g
s/\binitilaize\b/initialize/g
s/\bintializer\b/initializer/g
s/\blicence\b/license/g
s/\bminumum\b/minimum/g
s/\bmonotomic\b/monotonic/g
s/\boccasionaly\b/occasionally/g
s/\boccurences\b/occurrences/g
s/\bothervise\b/otherwise/g
s/\bpartiton\b/partition/g
s/\bprerpocessed\b/preprocessed/g
s/\bquailified\b/qualified/g
s/\brecieve\b/receive/g
s/\bretrurn\b/return/g
s/\bretured\b/returned/g
s/\bsclalar\b/scalar/g
s/\bsence\b/sense/g
s/\bseparatly\b/separately/g
s/\bsepated\b/separated/g
s/\bserialised\b/serialized/g
s/\bsucessfull\b/successful/g
s/\bsucessfuly\b/successfully/g
s/\bsuperflous\b/superfluous/g
s/\bsynonims\b/synonyms/g
s/\btranform\b/transform/g
s/\btransfering\b/transferring/g
s/\buntill\b/until/g

@alexey-milovidov alexey-milovidov merged commit cd874be into ClickHouse:master Jan 22, 2019
@alexey-milovidov
Copy link
Member

Thank you!

I wonder did you perform manual proofread or have used some automated spell check to find notable mistakes?

@maiha
Copy link
Contributor Author

maiha commented Jan 22, 2019

@alexey-milovidov

  1. detecting is automated by using aspell like this.
cat **/*.cpp | grep '///' | aspell -a | cut -d ' ' -f 2 | grep -v '*' | sort | uniq > typo.txt
  1. proofread is manual. So it was limited to dbms for this time.

I'll try to check whole src when I have a time 😸

@maiha maiha deleted the dbms-fix-misspells branch January 23, 2019 08:41
@alexey-milovidov
Copy link
Member

alexey-milovidov commented Jan 24, 2019

A few notes:

  • you can also search for header .h files (most of the comments are there);
  • you can also look for multiline comments (we usually write them as
/** ...
  * ...
  */

)

I wonder if we can integrate spell check to our CI process. But there are too many exceptions (spell checker don't like gcc, LLVM, buf, etc.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants