Fix fds close logic #4120
Merged
Fix fds close logic #4120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvartolomei
approved these changes
Jan 22, 2019
| for (; itr != end; ++itr) | ||
| std::vector<std::string> fds; | ||
| /// in /proc/self/fd directory filenames are numeric file descriptors | ||
| proc_path.list(fds); |
There was a problem hiding this comment.
lgtm as a temporary fix as this routine looks dodgy anyway :)
There was a problem hiding this comment.
Same code can be found in python sources, for example https://github.com/python/cpython/blob/6f9bc72c79c3262e5d0f2c0e96b016477399cfb1/Modules/_posixsubprocess.c#L211-L383.
There was a problem hiding this comment.
Thank you for the fix!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
For changelog. Remove if this is non-significant change.
Category (leave one):
Short description (up to few sentences):
Fix buf with closing /proc/self/fd earlier than all fds were read from /proc.