New functions filesystemAvailable, filesystemFree and filesystemCapacity #4097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexey-milovidov
approved these changes
Jan 18, 2019
|
Missing test. |
|
what kind of test can I write? because I can't check that the returned value is correct (at least not in stateless sql scripts). So just a simple test which checks that the functions return something? |
alexey-milovidov
added a commit
that referenced
this pull request
Jan 18, 2019
|
Yes, just a minimal test. I've added one. |
|
ok, thank you. |
|
A bug has been found: #38423 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Category:
The functions filesystemAvailable, filesystemFree and filesystemCapacity allow to get information on the space usage of data directory. This can be useful to get these simple information inside Clickhouse.