Custom compression codecs #3899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
alesapin
changed the title
|
It's not 100% ready, I still can do some refactoring and optimizations. However I'd be glad to see some review notices. |
|
00653_verification_monotonic_data_load and 00700_decimal_round broken in master. 00806_alter_update in unbundled mode seems strange. |
| if (options.count("level")) | ||
| level = options["level"].as<int>(); | ||
|
|
||
| DB::CompressionCodecPtr codec = DB::CompressionCodecFactory::instance().get(method_family, level); |
There was a problem hiding this comment.
You can also introduce --codec option that will allow to pass stacked codecs.
There was a problem hiding this comment.
…use into custom_compression_codecs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Category (leave one):
Short description (up to few sentences):
Add custom compression codecs.