-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Match the process' effective user id against the data owner at the server startup. #3785
Merged
alexey-milovidov
merged 14 commits into
ClickHouse:master
from
sergey-v-galtsev:match-process-euid-against-data-owner
Dec 23, 2018
Merged
Match the process' effective user id against the data owner at the server startup. #3785
alexey-milovidov
merged 14 commits into
ClickHouse:master
from
sergey-v-galtsev:match-process-euid-against-data-owner
Dec 23, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tch-process-euid-against-data-owner
Use getpwnam_r instead of getpwnam. Fix style.
filimonov
reviewed
Dec 10, 2018
alexey-milovidov
requested changes
Dec 10, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes required.
…b.com/sergey-v-galtsev/ClickHouse into match-process-euid-against-data-owner
…_R_SIZE_MAX) value.
const auto effective_user = getUserName(effective_user_id); | ||
if (stat(path.c_str(), &statbuf) == 0 && effective_user_id != statbuf.st_uid) | ||
{ | ||
const auto effective_user = getUserName(effective_user_id); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate.
alexey-milovidov
added a commit
that referenced
this pull request
Dec 23, 2018
alexey-milovidov
added a commit
that referenced
this pull request
Dec 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en