Versatile StorageJoin #3728
Merged
Versatile StorageJoin #3728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amosbird
force-pushed
the
join
branch
2 times, most recently
from
2cf86d5 to
27b1b95
Compare
This commit does the following: 1. StorageJoin with simple keys now supports reading 2. StorageJoin can be created with Join settings applied. Syntax is similar to MergeTree and Kafka 3. Left Any StorageJoin with one simple key can be used as a dictionary-like structure by function joinGet. Examples are listed in the related test file.
| const Context & context; | ||
| }; | ||
|
|
||
| } |
There was a problem hiding this comment.
In new convention, you just write all implementation in joinGet.cpp
| void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) override; | ||
|
|
||
| private: | ||
| bool isVariadic() const override { return true; } |
| + ", expected a const string.", | ||
| ErrorCodes::ILLEGAL_TYPE_OF_ARGUMENT}; | ||
|
|
||
| auto table = context.getTable("", join_name); |
There was a problem hiding this comment.
Why we support only current database?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit does the following:
StorageJoin with simple keys now supports reading, somehow related to allow reading from a SET storage #1656
StorageJoin can be created with Join settings applied. Syntax is
similar to MergeTree and Kafka
Left Any StorageJoin with one simple key can be used as a
dictionary-like structure by function joinGet.
Examples are listed in the related test file.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en