New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

timeSlots: add optional parameter 'Size' #3724

Merged

alexey-milovidov merged 1 commit into ClickHouse:master from ClickHouse-Ninja:master

Dec 2, 2018

Contributor

kshvakov commented Dec 1, 2018

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en


          timeSlots: add optional parameter 'Size'

566644b

alexey-milovidov merged commit c5dac3d into ClickHouse:master

alexey-milovidov added the can be tested label

alexey-milovidov added a commit that referenced this pull request


          Fixed errors and improved PR #3724

c9b8cd0

Member

alexey-milovidov commented Dec 2, 2018

I've fixed the following:

obsolete comment;
possible integer division in every iteration of a loop;
utilize "useDefaultImplementationForConstants" to avoid code for const-const case;
allow any unsigned integer types for "size" argument;
fixed error with exception message when type of "size" argument is wrong (there was a typo of argument index).

alexey-milovidov self-requested a review

December 2, 2018 00:51

filimonov mentioned this pull request

Add third parameter for timeSlot() function #2085

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet