Running daemon in custom environment #3612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
proller
reviewed
Nov 20, 2018
debian/clickhouse-server.init
Outdated
| @@ -36,6 +36,11 @@ command -v flock >/dev/null && FLOCK=flock | |||
| # Override defaults from optional config file | |||
| test -f /etc/default/clickhouse && . /etc/default/clickhouse | |||
|
|
|||
| # Environment for run daemon | |||
| if [ -f /etc/sysconfig/$PROGRAM ]; then | |||
There was a problem hiding this comment.
Also we should support /etc/default for debian based systems.
There was a problem hiding this comment.
Ok, I can transfer PROGRAM_ENV to /etc/default/clickhouse.
There was a problem hiding this comment.
@proller also suggested that we can simply source (.) this file instead of manual parsing.
|
We cannot find the reason why the child process is not terminated with parent. |
|
With original initscript: [root@reporting-dev1 init.d]# ./clickhouse-server start
Start clickhouse-server service: Path to data directory in /etc/clickhouse-server/config.xml: /var/lib/clickhouse/
DONE
[root@reporting-dev1 init.d]# ps axw | grep clickhouse
18665 ? Ssl 0:00 clickhouse-server --daemon --pid-file=/var/run/clickhouse-server/clickhouse-server.pid --config-file=/etc/clickhouse-server/config.xml
18672 ? Sl 0:03 /bin/clickhouse odbc-bridge --http-port 9018 --listen-host localhost --http-timeout 1800000000
18719 pts/3 S+ 0:00 grep --color=auto clickhouse
[root@reporting-dev1 init.d]# ps e --forest -g 18665
PID TTY STAT TIME COMMAND
18672 ? Sl 0:03 /bin/clickhouse odbc-bridge --http-port 9018 --listen-host localhost --http-timeout 1800000000 XDG_SESSION_ID=133 HOSTNAME=reporting-dev1 TERM=xterm-256color SHELL=/bin/bash H
18665 ? Ssl 0:00 clickhouse-server --daemon --pid-file=/var/run/clickhouse-server/clickhouse-server.pid --config-file=/etc/clickhouse-server/config.xml XDG_SESSION_ID=133 HOSTNAME=reporting-de
[root@reporting-dev1 init.d]# ./clickhouse-server stop
Stop clickhouse-server service: DONE
[root@reporting-dev1 init.d]# ps axw | grep clickhouse
18672 ? Sl 0:03 /bin/clickhouse odbc-bridge --http-port 9018 --listen-host localhost --http-timeout 1800000000
18772 pts/3 S+ 0:00 grep --color=auto clickhousein log: |
|
Yes, we have confirmed that it is not terminated by default. We will try to find the reason. |
|
Ok, I remove this code. |
|
@proller @alexey-milovidov @alesapin |
|
Если сейчас помержить, по получится, что одна из изначальных задач данного PR не решена (остановка odbc-bridge при завершении clickhouse-server). Последние два дня выясняли, почему он не останавливается сам. И в результате, есть такой PR: #3642 |
|
Впрочем, так как это было дополнительным пунктом, то просто мержим. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
It's need to connect dictionaries from oracle with using cyrillic support (set env for odbc-bridge
NLS_LANG=AMERICAN_AMERICA.AL32UTF8andLANG=en_US.UTF-8).And I fix terminating
clickhouse odbc-bridgewhere main process was stoped.