-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update firstSignificantSubdomain function #3601
Conversation
Added gov, mil, edu 2nd level domains
It should not if we will use carefully crafted hash table. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing test.
Look at dbms/tests/queries directory.
You can also provide a performance test to test for performance degradation. |
Performance is degraded by 12% on URLs from Yandex.Metrica.
From 0.137 sec. to 0.153 sec. |
Performance has been improved up to 0.116 sec by 2662594 |
Added
gov
,mil
andedu
2nd level domains.I also parsed the public suffix list (https://publicsuffix.org/list/public_suffix_list.dat) to get the most popular 2nd level domains, and here's the top ones:
(on the left - amount of TLDs that have such 2nd level domain)
I guess it'd be a performance issue to use the whole public suffix list?
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en